Support multi-column aliases in SELECT items#2289
Open
funcpp wants to merge 1 commit intoapache:mainfrom
Open
Conversation
Spark SQL grammar allows parenthesized identifier lists as SELECT
item aliases:
namedExpression: expression (AS? (identifier | identifierList))?
identifierList: '(' identifier (',' identifier)* ')'
This enables syntax like:
SELECT stack(2, 'a', 'b', 'c', 'd') AS (col1, col2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for parenthesized multi-column aliases in SELECT items, as defined in the Spark SQL grammar:
This enables syntax like:
Changes
SelectItem::ExprWithAliasesvariant for multi-column aliasesDialect::supports_select_item_multi_column_alias(), enabled for Databricks and Generic dialectsAS (ident, ident, ...)when the dialect supports itContext
While not documented in the Databricks SQL reference, this syntax is part of the Spark SQL grammar that Databricks implements. Verified to execute successfully on Databricks Runtime:
Test plan
SELECT stack(...) AS (col1, col2)with and without FROMcargo fmt,cargo clippy, full test suite pass